Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CommonJS example #1

Merged
merged 2 commits into from
Mar 1, 2018
Merged

Remove CommonJS example #1

merged 2 commits into from
Mar 1, 2018

Conversation

thegreatercurve
Copy link
Owner

Problem

  • The production bundle is not compiling to CommonJS.
  • Users cannot import the package using the require syntax.

Solution

  • Remove the CommonJS example from README.md.
  • Refactor the build config in a separate PR.

@thegreatercurve thegreatercurve added the bug Something isn't working label Mar 1, 2018
@thegreatercurve thegreatercurve self-assigned this Mar 1, 2018
Repository owner deleted a comment from coveralls Mar 1, 2018
@thegreatercurve thegreatercurve changed the title Bundle not compiling to CommonJS Remove CommonJS example Mar 1, 2018
@thegreatercurve thegreatercurve merged commit 3c28320 into master Mar 1, 2018
@thegreatercurve thegreatercurve deleted the bug/common-js-errors branch March 1, 2018 14:56
@thegreatercurve thegreatercurve mentioned this pull request Mar 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thegreatercurve thegreatercurve

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thegreatercurve