Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How is the Posts Service returning data? #51

Open
paul-barry-kenzan opened this issue Dec 13, 2016 · 1 comment
Open

How is the Posts Service returning data? #51

paul-barry-kenzan opened this issue Dec 13, 2016 · 1 comment
Milestone
Testing Improvements

Comments

@paul-barry-kenzan
Copy link

The Posts Service spec which verifies the number of posts is seemingly returning live data via the getPosts() method. Is this the case? Ideally, the data should be mocked somewhere/somehow, but I'm not seeing that. Could you clarify?

Even when testing the actual service, it's best to avoid any over-the-wire communication to ensure the service is isolated.
@thescientist13
Copy link
Member

busted. 😊

yes, it should be mocked. I suppose I glossed over that fact since PostsService is just returning a canned list of posts.

@thescientist13 thescientist13 added this to the Testing Improvements milestone Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Testing Improvements
Development

No branches or pull requests
2 participants
@thescientist13 @paul-barry-kenzan