Fix sonar issue

thegreenter · May 2, 2023 · 0c1425b · 0c1425b
1 parent 7e6f004
commit 0c1425b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/ws/src/Api/ApiFactory.php b/packages/ws/src/Api/ApiFactory.php
@@ -9,6 +9,7 @@
 use Exception;
 use Greenter\Services\Api\BasicToken;
 use Greenter\Services\Api\TokenStoreInterface;
+use Greenter\Services\InvalidServiceResponseException;
 use Greenter\Sunat\GRE\Api\AuthApiInterface;
 use Greenter\Sunat\GRE\Api\CpeApi;
 use Greenter\Sunat\GRE\Api\CpeApiInterface;
@@ -80,7 +81,7 @@ private function getToken(?string $clientId, ?string $secret, ?string $user, ?st
 
         $token = $result->getAccessToken();
         if (empty($token)) {
-            throw new Exception('Cliente No autorizado');
+            throw new InvalidServiceResponseException('Cliente No autorizado');
         }
 
         $expire =  $this->addSeconds(new DateTime(), $result->getExpiresIn());

diff --git a/packages/ws/tests/Ws/Api/ApiFactoryTest.php b/packages/ws/tests/Ws/Api/ApiFactoryTest.php
@@ -7,6 +7,7 @@
 use DateTime;
 use Greenter\Api\ApiFactory;
 use Greenter\Api\InMemoryStore;
+use Greenter\Services\InvalidServiceResponseException;
 use Greenter\Sunat\GRE\Api\AuthApiInterface;
 use Greenter\Sunat\GRE\Api\CpeApi;
 use Greenter\Sunat\GRE\Model\ApiToken;
@@ -38,7 +39,7 @@ public function testCreate()
 
     public function testInvalidToken()
     {
-        $this->expectException(\Exception::class);
+        $this->expectException(InvalidServiceResponseException::class);
         list ($auth, $client, $store) = $this->deps(1,'');
         $factory = new ApiFactory($auth, $client, $store, null);
         $factory->create('x', 'x', '20123456780MODDATOS', 'moddatos');