Build our tests with Travis and add postgresql to our testing matrix #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendjantetteroo
force-pushed
the
travis
branch
2 times, most recently
from
5baff9c
to
8d5a430
Compare
arendjantetteroo
changed the title
mrchrisadams
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Hi @arendjantetteroo I agree with the suggestions in your pull request and I think we gain more from having a simple code base and removing the files.
Feel free to merge/rebase once we've got rid of the unneeded files.
arendjantetteroo
force-pushed
the
travis
branch
from
b81331f
to
88111d5
Compare
This was referenced Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the travis build tool to the mix and removes the google cloud build stuff.
This adds phpstan checks so we avoid stupid mistakes that can be caught by a static code analyzer.
We also add postgres to the testing matrix mix and fix a couple things to make this work against a postgres database as well. Most important change to make that happen is testing
activevs a stringified true/false like'true'and'false'. Apperently otherwise postgres doesn't correctly convert those values into something the database can query for.