Make Ember a provider for use in exporter #24
Conversation
api/provider.go
Outdated
| @@ -5,5 +5,6 @@ import ( | |||
| ) | |||
|
|
|||
| type Provider interface { | |||
| GetAllRegionsCarbonIntensity(ctx context.Context) (map[string]float64, error) | |||
There was a problem hiding this comment.
This adds a new method to the interface for fetching all counties and their carbon intensity.
To add year as we're discussing in thegreenwebfoundation/grid-intensity-exporter#7 we'll need to change the returned types here.
But I'd prefer to do that as a follow up as these changes are already quite big. Is that OK?
There was a problem hiding this comment.
Yes, let's defer that decision.
electricitymap/client.go
Outdated
| @@ -41,6 +41,10 @@ type ApiClient struct { | |||
| token string | |||
| } | |||
|
|
|||
| func (a *ApiClient) GetAllRegionsCarbonIntensity(ctx context.Context) (map[string]float64, error) { | |||
| return nil, ErrNotSupported | |||
| } | |||
There was a problem hiding this comment.
For ElectricityMap this would involve a lot of API calls IIUC
So we just error if someone tries to use this.
ember/data.go
Outdated
| } | ||
|
|
||
| data[countryCode] = GridIntensity{ | ||
| CountryCode: countryCode, |
There was a problem hiding this comment.
Hey Ross - I've linked to CSV data here with both sets of country codes. If we had both sets here, we'd be able to support 2 and 3 character lookups.
thegreenwebfoundation/grid-intensity-exporter#7 (comment)
The columns here are comparable, but I'm not sure if we should include the column about emissions type - there are definite differences between marginal and average carbon intensity, but that might be better managed at the provider choice instead.
There was a problem hiding this comment.
Being able to do lookups with either format would be really useful.
I'll add the 2 char codes to the current file from the CSV you provided. It would also be great if Ember can add that upstream.
|
Hey Ross, I'm really happy with this. I agree with the decisions to defer the date / time discussion to another PR |
|
Feel free to merge whenever you're comfortable doing so. |
|
The data file now has both the 2 and 3 char country codes. I wrote a little go program to map them from the CSV data you gave me. I'll add it as a follow up PR. I've tested with the exporter and looks fine so going to go with this. |
Towards thegreenwebfoundation/grid-intensity-exporter#7