Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code generation to reflect changes merged from as/rest #214

Open
anschweitzer opened this issue Oct 27, 2023 · 0 comments
Open

Update code generation to reflect changes merged from as/rest #214

anschweitzer opened this issue Oct 27, 2023 · 0 comments
Assignees
@anschweitzer

Comments

@anschweitzer
Copy link
Collaborator

anschweitzer commented Oct 27, 2023 •
edited
Loading

PR 205 will probably break code generation.

Expected issues:

  1. At least one enum has been modified by hand.
  2. The base classes ComponentGt and ComponentAttributeClassGt have been modified by hand.
  3. New CACs and Components added by the PR are not autogenerated. I propose we keep them that way (this is a topic for discussion and/or experimention).
    1. The new CACs are simple and could probably be auto-generated without trouble.
    2. Some of the new Components of new components are simple and probably could be auto-generated (possibly only Fibaro Smart Implant)
    3. Other new Components have structural complexity and/or non-trivial code associated with them. It's unclear if autogeneration could usefully represent the structural complexity and the non-trivial code might mean a lot of code editing with an xslt intermediary which might be sub-optimal.
@anschweitzer anschweitzer self-assigned this Oct 27, 2023
@anschweitzer anschweitzer mentioned this issue Oct 27, 2023
Merged
anschweitzer added a commit that referenced this issue Oct 31, 2023
@anschweitzer
Tank Module via HTTP/Hubitat/Fibaro (#205)
353386c 
This PR adds support for Tank modules accessed by sending HTTP polls to a Hubitat which is configured to communicate with Fibaro Smart Implant temperature sensors on the tank via Fibaro / Hubitat ZWave network. 

Changes: 
1. New CACS, Components and enums added for Fibaro Smart Implant, Hubitat, Hubitat Tank Module and generic RESTPoller. 
2. HardwareLayout has been modified: 
    1. Components and CACS in OtherComponents/OtherCACs can be decoded from TypeName without need to specify the decoding class. 
    2. A "resolve" phase has been added after loading CACs, Components and Nodes to allow validation of relationships between entities when that validation requires all CACs, Components and Nodes to have been decoded. 
3. Code generation has been broken by this merge. Fixing up code generation will be addressed by #214. More code generation discussion in #215.
@anschweitzer anschweitzer mentioned this issue Oct 31, 2023
Merged
anschweitzer added a commit that referenced this issue Oct 31, 2023
@anschweitzer
Merge pull request #216 from thegridelectric/dev
fc1aefc 
Tank Module via HTTP/Hubitat/Fibaro (#205)

This PR adds support for Tank modules accessed by sending HTTP polls to a Hubitat which is configured to communicate with Fibaro Smart Implant temperature sensors on the tank via Fibaro / Hubitat ZWave network. 

Changes: 
1. New CACS, Components and enums added for Fibaro Smart Implant, Hubitat, Hubitat Tank Module and generic RESTPoller. 
2. HardwareLayout has been modified: 
    1. Components and CACS in OtherComponents/OtherCACs can be decoded from TypeName without need to specify the decoding class. 
    2. A "resolve" phase has been added after loading CACs, Components and Nodes to allow validation of relationships between entities when that validation requires all CACs, Components and Nodes to have been decoded. 
3. Code generation has been broken by this merge. Fixing up code generation will be addressed by #214. More code generation discussion in #215.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anschweitzer anschweitzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anschweitzer