Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start an activity without choosing a tag #13

Closed
thehale opened this issue Feb 19, 2024 · 0 comments
Closed

Start an activity without choosing a tag #13

thehale opened this issue Feb 19, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@thehale
Copy link
Owner

thehale commented Feb 19, 2024

To start an activity, currently one MUST choose a tag. That's not a requirement on the phone app.

When an activity has one or more tags available as options, starting the activity with zero associated tags should still be possible.

This feature request is subtly different from the bug reported in #12. That bug applies when zero tags are available for association with the chosen activity. This feature request is for the ability to elect to choose zero out of a set of available tags when starting an activity.
@thehale thehale added the enhancement New feature or request label Feb 19, 2024
@thehale thehale added this to the 1.0.0 milestone Feb 19, 2024
@thehale thehale mentioned this issue Feb 19, 2024
Closed
@kantahrek kantahrek mentioned this issue Feb 21, 2024
Merged
thehale added a commit that referenced this issue Feb 24, 2024
@thehale
feat: Support tag selection mode setting
6dcae34 
On the phone, the user can request for activities to be started
immediately after picking one tag, or after picking multiple.

With this commit, that behavior is reflected in the WearOS app.

Additionally, the new Submit button on the TagList allows users
to start the activity from the TagsScreen, but without picking
any tags, so it further satisfies #13

closes thehale/SimpleTimeTracker#16
closes thehale/SimpleTimeTracker#17
thehale added a commit that referenced this issue Feb 24, 2024
@thehale
feat: Support tag selection mode setting
9cf4b32 
On the phone, the user can request for activities to be started
immediately after picking one tag, or after picking multiple.

With this commit, that behavior is reflected in the WearOS app.

Additionally, the new Submit button on the TagList allows users
to start the activity from the TagsScreen, but without picking
any tags, so it further satisfies #13

closes #16
closes #17
thehale added a commit that referenced this issue Feb 27, 2024
@thehale
refactor: Hoist all rpc calls to ActivitiesScreen
047c536 
Components are more reusable when they have minimal state
and/or dependency on outside resources.

This commit raises the rpc calls to `ActivitiesScreen` which has
the responsibility for managing the data flow and interactions
between components.

This update also fixes a few bugs:
 - Tapping an activity chip will start the activity if it doesn't have
   any tags.
 - The switches now update automatically after an activity is started or
   stopped.

closes #12
closes #13
thehale added a commit that referenced this issue Feb 27, 2024
@thehale
feat: Support tag selection mode setting
4c19b30 
On the phone, the user can request for activities to be started
immediately after picking one tag, or after picking multiple.

With this commit, that behavior is reflected in the WearOS app.

Additionally, the new Submit button on the TagList allows users
to start the activity from the TagsScreen, but without picking
any tags, so it further satisfies #13

closes #16
closes #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@thehale