Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

glowing-bear-ssl-proxy should not rely on docker IP addresses #44

Open
tgymnich opened this issue Dec 14, 2019 · 1 comment · May be fixed by #45
Open

glowing-bear-ssl-proxy should not rely on docker IP addresses #44

tgymnich opened this issue Dec 14, 2019 · 1 comment · May be fixed by #45
Labels
enhancement New feature or request

Comments

@tgymnich
Copy link
Contributor

glowing-bear-ssl-proxy should not rely on internal docker IP addresses since they might be different on some systems. Using dns names and docker networks is more flexible and reliable. I suggest using the docker networks defined in docker-compose.yml and keycloak.yml. This can also reduce the number of ports exposed to the outside and thus improve security.

External networks can be used like this:

networks:
  default:
    external:
      name: my-pre-existing-network
@gijskant
Copy link
Contributor

Sounds like a good improvement. Indeed, using the internal Docker IP address feels like a hack. We were not aware of the possibility to refer to an external network.
Could you create a PR for this?

@gijskant gijskant added the enhancement New feature or request label Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
2 participants