This repository has been archived by the owner on Jun 20, 2018. It is now read-only.
Add notification manager API #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidolob
reviewed
Apr 23, 2018
| }; | ||
|
|
||
| export const MAIN_RPC_CONTEXT = { | ||
| HOSTED_PLUGIN_MANAGER_EXT: createProxyIdentifier<HostedPluginManagerExt>('HostedPluginManagerExt'), | ||
| COMMAND_REGISTRY_EXT: createProxyIdentifier<CommandRegistryExt>('CommandRegistryExt'), | ||
| QUICK_OPEN_EXT: createProxyIdentifier<QuickOpenExt>('QuickOpenExt') | ||
| QUICK_OPEN_EXT: createProxyIdentifier<QuickOpenExt>('QuickOpenExt'), | ||
| MESSAGE_REGISTRY_EXT: createProxyIdentifier('MessageRegistryExt') |
There was a problem hiding this comment.
Why you add this MESSAGE_REGISTRY_EXT ? Is this used anywhere?
There was a problem hiding this comment.
I used it in plugin-context.ts
https://github.com/theia-demo-plugins/wiptheia/pull/2/files#diff-761ce14ea07b1d3bb10a3b02a8fb1763R22
evidolob
reviewed
Apr 23, 2018
|
|
||
| export function createAPI(rpc: RPCProtocol): typeof theia { | ||
| const commandRegistryExt = rpc.set(MAIN_RPC_CONTEXT.COMMAND_REGISTRY_EXT, new CommandRegistryImpl(rpc)); | ||
| const quickOpenExt = rpc.set(MAIN_RPC_CONTEXT.QUICK_OPEN_EXT, new QuickOpenExtImpl(rpc)); | ||
| const messageRegistryExt = rpc.set(MAIN_RPC_CONTEXT.MESSAGE_REGISTRY_EXT, new MessageRegistryExt(rpc)); |
There was a problem hiding this comment.
You don't need to do rpc.set, as your MessageRegistryExt is never called from Theia core part
There was a problem hiding this comment.
Ok. I just added a mechanism for possible future In the first realization. I'll remove.
evidolob
approved these changes
Apr 23, 2018
4 tasks
benoitf
approved these changes
Apr 23, 2018
benoitf
force-pushed
the
master
branch
2 times, most recently
from
e8a9416
to
fdd626c
Compare
evidolob
approved these changes
May 7, 2018
benoitf
reviewed
May 7, 2018
| .dialogContent .theia-Notification .icon { | ||
| font-size: 20px; | ||
| padding: 5px 0; | ||
| } |
Signed-off-by: Oleksii Orel <oorel@redhat.com>
benoitf
approved these changes
May 7, 2018
benoitf
pushed a commit
that referenced
this pull request
May 29, 2018
Signed-off-by: Oleksii Orel <oorel@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 4, 2018
Signed-off-by: Oleksii Orel <oorel@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 13, 2018
Signed-off-by: Oleksii Orel <oorel@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 18, 2018
Signed-off-by: Oleksii Orel <oorel@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 18, 2018
Signed-off-by: Oleksii Orel <oorel@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 19, 2018
Signed-off-by: Oleksii Orel <oorel@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 19, 2018
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add notification manager API to the new plugin system.
Discussion about architecture and principles can be found here: eclipse-theia#1482
This API allows implementation of notifications to show an information message. Optionally provide an array of items which will be presented as clickable buttons and can be shown using the showInformationMessage,
showWarningMessage and showErrorMessage functions.
Simple example that show an information message:
Simple example that show an information message with buttons:
eclipse-che/che#9525
Both kind of notifications with buttons:
Signed-off-by: Oleksii Orel oorel@redhat.com