Updates for node 14+ and newer dependencies #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @daniel-brenot Any update on that PR? |
Still waiting on this to be merged in. |
|
Am I correct to assume that it's the one missing dependency to really make Theia compatible with Node.js 14 @kittaakos ? The 12.x EOL is coming soon https://nodejs.org/en/about/releases/ and we should likely get ready to upgrade to 14.x as soon as possible. |
msujew
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates most of the project dependencies, and removes the restriction on node max version.
This also fixes some of the tests that were broken based on the commit date sorting on macos. The tests all pass on travisCI now.