Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support language specific editor preferences #1106

Closed
simark opened this issue Jan 22, 2018 · 7 comments · Fixed by #4296
Closed

Support language specific editor preferences #1106

simark opened this issue Jan 22, 2018 · 7 comments · Fixed by #4296
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences vscode issues related to VSCode compatibility

Comments

@simark
Copy link
Contributor

simark commented Jan 22, 2018

Makefile syntax requires tab character for indentation, not spaces. Is it possible to do this currently with Theia? If so, how?

@hexa00
Copy link

hexa00 commented Jan 23, 2018

You can set the monaco editor settings in .theia/settings.json IIRC
@epatpol I think you would know more ?

@epatpol
Copy link
Contributor

epatpol commented Jan 23, 2018

Yes you can set settings available here, however I'm not sure if the monaco editor supports doing tabs instead of spaces... Maybe it's there somewhere in their documentation I'm not sure.

@simark
Copy link
Contributor Author

simark commented Jan 23, 2018

But this is not really practical if you need other files to use space as indentation. I guess my question is more, how do we better handle per-file indentation settings. In VScode you can click in the status bar to change them quickly.

@akosyakov
Copy link
Member

In VS code also such preferences can be configured per a language.

@epatpol
Copy link
Contributor

epatpol commented Jan 23, 2018

Yes there should be different editors for different file types, maybe not completely different editors like in Eclipse (open with -> tons of choice) but maybe a user could create a new "editor", associate custom preferences to this one only and decide to use this one for certain files etc.

I'm not even sure this setting exists for monaco to solve this issue though.

@akosyakov
Copy link
Member

akosyakov commented Jan 23, 2018

It is not supported at the moment. We can implement it like in VS code: https://code.visualstudio.com/docs/getstarted/settings#_language-specific-editor-settings

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences labels Jan 23, 2018
@akosyakov akosyakov changed the title How to edit a Makefile with Theia Support language specific editor preferences Jan 23, 2018
@kittaakos
Copy link
Contributor

Yes there should be different editors for different file types

Related? #335

@akosyakov akosyakov self-assigned this Aug 3, 2018
@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Feb 5, 2019
akosyakov added a commit that referenced this issue Feb 7, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Feb 7, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Feb 8, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Feb 8, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
svenefftinge pushed a commit that referenced this issue Feb 11, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants