Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plug-in] Implement 'configurationDefault' contribution point #3540

Closed
akurinnoy opened this issue Nov 19, 2018 · 6 comments · Fixed by #4296
Closed

[plug-in] Implement 'configurationDefault' contribution point #3540

akurinnoy opened this issue Nov 19, 2018 · 6 comments · Fixed by #4296
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system preferences issues related to preferences

Comments

@akurinnoy
Copy link
Contributor

akurinnoy commented Nov 19, 2018

contributes.configurationDefaults

Configuration example:

"contributes": {
    "configurationDefaults": {
        "[markdown]": {
            "editor.wordWrap": "on",
            "editor.quickSuggestions": false
        }
    }
}
@akurinnoy akurinnoy self-assigned this Nov 20, 2018
@akurinnoy akurinnoy added the plug-in system issues related to the plug-in system label Nov 20, 2018
@akosyakov
Copy link
Member

@akurinnoy Are you working on it?

@akurinnoy
Copy link
Contributor Author

@akosyakov not yet

@akosyakov
Copy link
Member

akosyakov commented Feb 5, 2019

@akurinnoy Is there a time frame when it can be implemented? It is needed for some built-in extensions and to fix vscode api tests.

@akurinnoy
Copy link
Contributor Author

@akosyakov unfortunately, we cannot take it in following sprint, but, we could do it in next sprint in 3 weeks, I think

@akosyakov
Copy link
Member

@akurinnoy Would it be alright if i look at it now?

@akurinnoy
Copy link
Contributor Author

@akosyakov Sure! Should I re-assign the issue?

@akosyakov akosyakov assigned akosyakov and unassigned akurinnoy Feb 5, 2019
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences labels Feb 5, 2019
akosyakov added a commit that referenced this issue Feb 7, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Feb 7, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Feb 8, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Feb 8, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
svenefftinge pushed a commit that referenced this issue Feb 11, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system preferences issues related to preferences
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants