-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Toolbar support for sidepanels and changed sidepanel tabs. #4600
Conversation
@jbicker build is broken and some nice screenshots in the description will be cool :) TODO:
|
@@ -174,6 +180,8 @@ export interface TabBarToolbarItem { | |||
*/ | |||
readonly when?: string; | |||
|
|||
onDidChange?: (handler: () => void) => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use Event<void>
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great just a few small improvements.
Also please change the label for our navigator from 'Files' to 'Explorer'. |
For https://marketplace.visualstudio.com/items?itemName=ms-vscode.references-view extension: There is no icon, duplicate title. Updated |
packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx
Outdated
Show resolved
Hide resolved
The active item is highlighted with blue line. The current item has black background right now, in addition to having 1 as opacity. I would be for aligning with VS Code and removing black background, only use opacity. |
packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx
Outdated
Show resolved
Hide resolved
fac3f76
to
911e13e
Compare
Every sidepanel has an header now where the title and a toolbar is shown (if tools are registered for that widget). As an example the control buttons of search in workspace extension are moved to the toolbar. Additionally the tabs of sidebars don't show labels anymore but icons. Fixes #3864 Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbicker looks good now, please proceed with merging
Hello, I've noticed this PR caused a regression on webview tabs there is an override with background: none I've created #4664 |
I commented on #4654 but it should be better to comment it there: I think it's misleading people to have extension icon of Theia being the same icon as VS Code extension as you might expect that you're able to use VSCode extensions while it's bring by plug-ins. So I would be more in favor of having plug-in icon being the same than vscode extension as you're managing the same packaging unit. |
@benoitf i don't care about extension-manager, we can just erase for now references to it from everywhere (examples, docs, images). plugin ext can us VS Code extension icon regardless of it. Also in docs we should include plugin-ext-vscode instead (see https://stackoverflow.com/questions/55254187/cant-find-hosted-mode-in-theia) Let's create an issue for it? |
Every sidepanel has an header now where the title and a toolbar
is shown (if tools are registered for that widget).
As an example the control buttons of search in workspace extension are
moved to the toolbar.
Additionally the tabs of sidebars don't show labels anymore but icons.
fIx #3864, fIx #716