Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement registerDebugAdapterTrackerFactory #5441

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jun 13, 2019

Signed-off-by: Anatoliy Bazko abazko@redhat.com

What does this PR do

Add VS Code api to register DebugAdapterTrackerFactory [1]
[1] https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L8861

Reference issue

#4804

How to test

I used my custom plugin [2] to print messages on console:

root INFO [hosted-plugin: 3553] onWillStartSession
root INFO [hosted-plugin: 3553] onWillReceiveMessage
root INFO [hosted-plugin: 3553] onWillStopSession
root INFO [hosted-plugin: 3553] onExit

[2] https://github.com/tolusha/pig-debugger-theia-plugin

@tolusha tolusha requested a review from akosyakov June 13, 2019 07:24
@tolusha tolusha self-assigned this Jun 13, 2019
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be interesting to try

which are using this function

@akosyakov
Copy link
Member

I like how @tolusha structured the description. Maybe we can update our PR template to encourage contributors list how to test and what to expect? cc @marcdumais-work @svenefftinge

@akosyakov
Copy link
Member

@tolusha How do you test with your extension? Could you provide steps?

I've tried to install it, but it does not recognise own generated initial config.
Screen Shot 2019-06-13 at 12 34 09

@tolusha
Copy link
Contributor Author

tolusha commented Jun 13, 2019

@akosyakov
use pig-debug type

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was able verify with pig extension

@akosyakov
Copy link
Member

@a1994846931931 if you can please give it a try after it gets merged

@tolusha
Copy link
Contributor Author

tolusha commented Jun 13, 2019

@akosyakov This PR allows to register debug adapter tracker factory only.
I am working on registration debug adapter descriptor factory and about to create another PR.
I've split the task into two different PRs

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha force-pushed the ab/registerDebugAdapterTrackerFactory branch from 15b8345 to cdf3d34 Compare June 13, 2019 15:34
@tolusha tolusha merged commit 025102a into master Jun 13, 2019
@tolusha tolusha deleted the ab/registerDebugAdapterTrackerFactory branch June 13, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants