-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement registerDebugAdapterTrackerFactory #5441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be interesting to try
which are using this function
I like how @tolusha structured the description. Maybe we can update our PR template to encourage contributors list how to test and what to expect? cc @marcdumais-work @svenefftinge |
packages/plugin-ext/src/plugin/node/debug/plugin-debug-adapter-tracker.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/plugin/node/debug/plugin-debug-adapter-session.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/plugin/node/debug/plugin-debug-adapter-session.ts
Outdated
Show resolved
Hide resolved
@tolusha How do you test with your extension? Could you provide steps? I've tried to install it, but it does not recognise own generated initial config. |
@akosyakov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was able verify with pig extension
@a1994846931931 if you can please give it a try after it gets merged |
@akosyakov This PR allows to register debug adapter tracker factory only. |
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
15b8345
to
cdf3d34
Compare
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do
Add VS Code api to register
DebugAdapterTrackerFactory
[1][1] https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L8861
Reference issue
#4804
How to test
I used my custom plugin [2] to print messages on console:
[2] https://github.com/tolusha/pig-debugger-theia-plugin