Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] support env variable substitution #5811

Merged
merged 1 commit into from
Jul 30, 2019
Merged

[vscode] support env variable substitution #5811

merged 1 commit into from
Jul 30, 2019

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jul 29, 2019

What it does

support env:NAME variable substitution, see VS Code doc: https://code.visualstudio.com/docs/editor/variables-reference#_environment-variables

How to test

Modify launch configuration to reference some env variable and launch it. See for example how PATH env variable is referenced in Run Mocha Test configuration below, and then PATH value is printed to the debug console:

Screen Shot 2019-07-29 at 15 11 50

Review checklist

Reminder for reviewers

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the PR with several simple tasks, like the following:

    }
      "label": "test env var",
      "type": "shell",
      "command": "sleep 1 && echo ${env:USER}"
    }

Works well!

@akosyakov
Copy link
Member Author

akosyakov commented Jul 29, 2019

@azatsarynnyy Would you be fine if i assign you for reviews more often? We need help with testing and ensuring quality. Even half an hour couple days a week would help.

@azatsarynnyy
Copy link
Member

@akosyakov sure, I don't mind 🙂
I'll be glad to help as much as possible for the common good.

Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well :)

Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as advertised!
Tested with command and args.

@akosyakov akosyakov merged commit 3a56c70 into master Jul 30, 2019
@akosyakov akosyakov deleted the ak/env_var branch July 30, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants