-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SingleTextInputDialog handle the enter key when mouse in the input box #5868
Conversation
Signed-off-by: xieyuanhu <xieyuanhuata@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only work when the mouse is in the input box
@xieyuanhuata isn't the change already handled in your previous PR https://github.com/theia-ide/theia/pull/5860/files#diff-a5093b632a0c8903b70f918cd8f64863R379-R384 ? |
@vince-fugnitto |
I was just trying to understand why another PR was opened with a subset of the first PRs changes. |
@vince-fugnitto I've closed #5860, applying of keyboard listener only to the top level dialog is handled in #5865. I think this PR handles another issue, that only input element should be focused. Could you review #5865 as well please? |
@vince-fugnitto @akosyakov |
It's alright, @akosyakov closed the original PR. |
@vince-fugnitto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works well 👍
If the input is not focused enter does not execute the dialog.
Only if the input is selected does enter work.
fix #5867
SingleTextInputDialog handle the enter key only when mouse in the input box
before
![11](https://user-images.githubusercontent.com/50982164/62529202-c73ca880-b870-11e9-8c5e-52e8c0321051.gif)
after
![good](https://user-images.githubusercontent.com/50982164/62529233-d91e4b80-b870-11e9-8fa0-3656ef6bf5c3.gif)
How to test:
Open 'New Folder' or 'Rename File' and press 'enter' in the space;