feat: support editor/title context menus for web views

[502647092]

Signed-off-by: MiaoWoo admin@yumc.pw

What it does

Fixed: #5515

How to test

• ext install humao.rest-client
• create http file google.http

GET http://google.com

• Send Request
• Webview have menus
  

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

Please take a look at failing CI.
Executing the tests for the @theia/plugin-ext is failing (ex: npx run test @theia/plugin-ext)

[vince-fugnitto]

I'm not sure this is the appropriate place for this type and namespace.
I don't expect menus-contribution-handler to have this information.

[502647092]

I copy the code from #5527 @akosyakov

[akosyakov]

@vince-fugnitto Where would you suggest to put it? It is require for now only for menu contributions to provide mapping between vscode core editor meaning to Theia.

[502647092]

Please take a look at failing CI.
Executing the tests for the @theia/plugin-ext is failing (ex: npx run test @theia/plugin-ext)

I test it in master branch
it's also error

[vince-fugnitto]

I test it in master branch
it's also error

I checked on the latest master ffcb3fa and there were no issues.

[502647092]

I test it in master branch
it's also error

I checked on the latest master ffcb3fa and there were no issues.

emm but in my workspace have error

[502647092]

@akosyakov
Do you know what caused the test to fail?

[vince-fugnitto]

@akosyakov
Do you know what caused the test to fail?

When checking out master did you, git clean -fdx and yarn and then run the test?

[502647092]

@vince-fugnitto
test failed because import webview -> MiniBrowserContent -> PDFObject

    //jshint unused:true

    //PDFObject is designed for client-side (browsers), not server-side (node)
    //Will choke on undefined navigator and window vars when run on server
    //Return boolean false and exit function when running server-side

    if(typeof window === "undefined" || typeof navigator === "undefined"){ return false; }

    var pdfobjectversion = "2.0.201604172",
        supportsPDFs,

        //declare functions
        createAXO,
        isIE,
        supportsPdfMimeType = (typeof navigator.mimeTypes['application/pdf'] !== "undefined"),

navigator.mimeTypes is undefined
but I don't know why will cause it failed
maybe is lose some deps before test

[502647092]

@vince-fugnitto
I create a new file to save const value
now test pass

[akosyakov]

After switching theme actions are not there anymore. They also don't seem to do anything when clicked, but it is probably another issue?

[502647092]

@akosyakov
There are some problems
Click once after menu will invalid
But I think it should be another problem.

[akosyakov]

approve since actions are there

there are 2 known issues still:

• focus for webviews is broken, because of it actions are not visible sometimes, see [vscode] webview active state is bogus if iframe is focused #5521
• actions don't do anything, since clipboard api is not yet implemented, see Clipboard API for Plugins #5994

Let's address them separately.