Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to build with Node 10 ? #3

Closed
elaihau opened this issue Apr 11, 2019 · 2 comments
Closed

How to build with Node 10 ? #3

elaihau opened this issue Apr 11, 2019 · 2 comments

Comments

@elaihau
Copy link

elaihau commented Apr 11, 2019

Recently Jacques and I have been playing with vscode builtin extensions such as grunt, gulp, npm, and jake to achieve the compatibility.

We built extensions from source available at https://github.com/theia-ide/vscode-builtin-extensions. And this morning we noticed that, some extensions, such as gulp, did not build any more since we moved to Node 10.

As vscode uses Node 10 since Feb (i.e., microsoft/vscode#68098), we thought using Node 10 on the latest released version of code would work. So, we updated vscode-builtin-extensions/vscode to 1.33.0 as a submodule and rebuilt, but it still failed.

[11:54:23] Using gulpfile ~/dev/vscode-builtin-extensions/vscode/gulpfile.js
[11:54:23] Task never defined: compile-extensions-build
[11:54:23] To list available tasks, try running: gulp --tasks
error Command failed with exit code 1.

is there a way to get around this error? Thanks !

@akosyakov
Copy link
Member

upgraded to vscode 1.33.0 to build with Node 10

@daisuke-yoshimoto
Copy link

@akosyakov
Could you publish vscode-builtin-extensions built with Node 10 to npm registry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants