consider placeholder values in cache key generation

theiconic · Aug 29, 2017 · 365cbec · 365cbec
1 parent 9f93bc2
commit 365cbec
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/Space.php b/src/Space.php
@@ -330,13 +330,17 @@ public function addPath($path): Space
     }
 
     /**
-     * get the path to the cache config file for the current environment
-     *
-     * @return string the file path
+     * @return string the cache key
      */
     protected function getCacheKey(): string
     {
-        return strtolower(md5(sprintf('%s_%s', implode('::', $this->getPaths()), implode('::', $this->getSections()))));
+        $parts = [
+            implode('::', $this->getPaths()),
+            implode('::', $this->getSections()),
+            json_encode($this->placeholders),
+        ];
+
+        return strtolower(md5(implode('_', $parts)));
     }
 
     /**