Enable lastname remapping - fixes #11 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Names like "SUJAN MASTER", "JAMES J MA", "PETER K MA" had the 'Master' or 'Ma' parts as special parts (salutations, suffixes) where they should be lastnames. In "PAUL M LEWIS MR", the lastname should be 'Lewis Mr'. This change does three things to fix this: Firstly, it prevents parsing for salutations beyond the first half of words in the given string. It also introduces a `setMaxSalutationIndex()` method to allow overriding this with a fixed maximum word index. E.g. setting it to 2 will require salutations to appear in the first two words. Secondly, if the lastname mapper does not derive a lastname, but has skipped ignored parts like suffix, nickname or salutation, it will convert these into lastname parts. Thirdly, the lastname mapper will now map more than one lastname part if the already mapped lastname parts are shorter than 3 characters and there will be at least one part left after mapping. This effectively maps 'Lewis' in 'Paul M Lewis Mr' as lastname instead of previously as middlename.
wyrfel
force-pushed
the
feature/lastname-remapping
branch
3 times, most recently
from
7173969
to
a1d94da
Compare
wyrfel
force-pushed
the
feature/lastname-remapping
branch
from
a1d94da
to
c850174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Names like "SUJAN MASTER", "JAMES J MA", "PETER K MA" had the 'Master'
or 'Ma' parts as special parts (salutations, suffixes) where they
should be lastnames. In "PAUL M LEWIS MR", the lastname should be
'Lewis Mr'.
This change does three things to fix this:
Firstly, it prevents parsing for salutations beyond the first half of words in
the given string. It also introduces a
setMaxSalutationIndex()methodto allow overriding this with a fixed maximum word index. E.g. setting
it to 2 will require salutations to appear in the first two words.
Secondly, if the lastname mapper does not derive a lastname, but has skipped
ignored parts like suffix, nickname or salutation, it will convert these into
lastname parts.
Thirdly, the lastname mapper will now map more than one lastname part if
the already mapped lastname parts are shorter than 3 characters and there
will be at least one part left after mapping. This effectively maps
'Lewis' in 'Paul M Lewis Mr' as lastname instead of previously as middlename.