Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDS and DVM Suffixes #44

Merged
merged 1 commit into from May 16, 2020
Merged

Conversation

HaroldPutman
Copy link
Contributor

There is a never-ending stream of professional suffixes, but these two in particular are used in Faker but aren't currently supported here.

These get generated by Faker.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9a62b31 on HaroldPutman:faker-suffixes into e40c25b on theiconic:master.

@HaroldPutman
Copy link
Contributor Author

HaroldPutman commented May 15, 2020

While looking into #42 I discovered that it is not hard to add domain-specific professional suffixes or salutations. But I still think these should be added since a new user who creates a Laravel factory and throws fake names against the out-of-the box parser might worry that this doesn't work well.

Copy link
Contributor

@wyrfel wyrfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HaroldPutman

@wyrfel wyrfel merged commit 8da40c7 into theiconic:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants