Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE unit tests are broken on CI #1037

Closed
jason0x43 opened this issue Jan 15, 2020 · 2 comments
Closed

IE unit tests are broken on CI #1037

jason0x43 opened this issue Jan 15, 2020 · 2 comments
Assignees
Labels
project-dev Updates to Intern's organization or dev process

Comments

@jason0x43
Copy link
Member

This is an issue with the current development version of Intern (5.0-pre).

From looking at BrowserStack logs, the problem seems to be that the remote test runner can't communicate with the host Intern. CI tests run fine on Chrome, though, so it's not a problem with the basic test setup.

Note that functional tests do work, so the host Intern can communicate with the remote IE and and send it commands.

@jason0x43 jason0x43 added the project-dev Updates to Intern's organization or dev process label Jan 15, 2020
@jason0x43 jason0x43 changed the title IE unit tests don't run on CI IE unit tests are broken on CI Jan 15, 2020
@jason0x43
Copy link
Member Author

The problem may be that remote execution scripts are being transpiled to ES2015 code.

× internet explorer 11 on WINDOWS - functional/webdriver/helpers/pollUntil - with args (2.769s)
    JavaScriptError: [POST https://(redacted)@hub.browserstack.com:443/wd/hub/session/1e5f14caa4488a5409ed83a6c10387215201835b/execute_async / {"script":"return (function(poller,args,timeout,pollInterval,done){/* jshint evil:true */poller=new Function(poller);const endTime=Number(new Date())+timeout;(function poll(){const result=poller.apply(this,args);/*jshint evil:true */if(result!=null){done(result);}else if(Number(new Date())<endTime){setTimeout(poll,pollInterval);}else{done(null);}})();}).apply(this, arguments);","args":["return (id => {\n                    return document.getElementById(id);\n                }).apply(this, arguments);",["d"],1000,67]}] JavaScript error in async script.

Note the arrow function in that code.

@jason0x43 jason0x43 self-assigned this Jan 17, 2020
jason0x43 added a commit that referenced this issue Jan 20, 2020
- Disable the brokenWindowSwitch test in IE (it hangs)
- Build browser tests as ES5
- Make loader scripts and RemoteSuite configuration script IE-friendly
- Add descriptive comments to tsconfig files
- Make webpack paths more Windows-friendly
- Make execute scripts IE-compatible
- Add a mouse click listener to one of the functional test pages to
  visualize click locations
- Add a pathRe function to create platform-compatible path-based regular
  expressions

references #1043
references #1037
@jason0x43
Copy link
Member Author

Resolved by a681b7f

jason0x43 added a commit to jason0x43/intern that referenced this issue Jul 7, 2020
- Disable the brokenWindowSwitch test in IE (it hangs)
- Build browser tests as ES5
- Make loader scripts and RemoteSuite configuration script IE-friendly
- Add descriptive comments to tsconfig files
- Make webpack paths more Windows-friendly
- Make execute scripts IE-compatible
- Add a mouse click listener to one of the functional test pages to
  visualize click locations
- Add a pathRe function to create platform-compatible path-based regular
  expressions

references theintern#1043
references theintern#1037
jason0x43 added a commit to jason0x43/intern that referenced this issue Jul 7, 2020
- Disable the brokenWindowSwitch test in IE (it hangs)
- Build browser tests as ES5
- Make loader scripts and RemoteSuite configuration script IE-friendly
- Add descriptive comments to tsconfig files
- Make webpack paths more Windows-friendly
- Make execute scripts IE-compatible
- Add a mouse click listener to one of the functional test pages to
  visualize click locations
- Add a pathRe function to create platform-compatible path-based regular
  expressions

references theintern#1043
references theintern#1037
jason0x43 added a commit to jason0x43/intern that referenced this issue Jul 13, 2020
- Disable the brokenWindowSwitch test in IE (it hangs)
- Build browser tests as ES5
- Make loader scripts and RemoteSuite configuration script IE-friendly
- Add descriptive comments to tsconfig files
- Make webpack paths more Windows-friendly
- Make execute scripts IE-compatible
- Add a mouse click listener to one of the functional test pages to
  visualize click locations
- Add a pathRe function to create platform-compatible path-based regular
  expressions

references theintern#1043
references theintern#1037
jason0x43 added a commit that referenced this issue Jul 21, 2020
- Disable the brokenWindowSwitch test in IE (it hangs)
- Build browser tests as ES5
- Make loader scripts and RemoteSuite configuration script IE-friendly
- Add descriptive comments to tsconfig files
- Make webpack paths more Windows-friendly
- Make execute scripts IE-compatible
- Add a mouse click listener to one of the functional test pages to
  visualize click locations
- Add a pathRe function to create platform-compatible path-based regular
  expressions

references #1043
references #1037
jason0x43 added a commit that referenced this issue Aug 10, 2020
- Disable the brokenWindowSwitch test in IE (it hangs)
- Build browser tests as ES5
- Make loader scripts and RemoteSuite configuration script IE-friendly
- Add descriptive comments to tsconfig files
- Make webpack paths more Windows-friendly
- Make execute scripts IE-compatible
- Add a mouse click listener to one of the functional test pages to
  visualize click locations
- Add a pathRe function to create platform-compatible path-based regular
  expressions

references #1043
references #1037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-dev Updates to Intern's organization or dev process
Projects
None yet
Development

No branches or pull requests

1 participant