Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reporters to be factory-created event listeners #1135

Open
jason0x43 opened this issue Apr 14, 2020 · 0 comments
Open

Refactor reporters to be factory-created event listeners #1135

jason0x43 opened this issue Apr 14, 2020 · 0 comments
Labels
domain-reporters Related to Intern's built-in reporters effort-medium This may take a couple of days priority-low We'll get to this eventually
Projects

Comments

@jason0x43
Copy link
Member

Currently reporters are all implemented as classes based on a Reporter root class. Internally, however, they are simply event listeners. The reporter class structure was intended to provide some shared functionality for reporters, but it really ends up being overhead, and it obscures how the reporter system actually works.

Reimplement reporters as simple event listeners created by factory functions. Put any shared functionality in a utility module or modules.

See #1023 (comment).

@jason0x43 jason0x43 added enhancement A new or improved feature effort-medium This may take a couple of days priority-medium This should get done, but it's not a high priority labels Apr 14, 2020
@github-actions github-actions bot added this to To do in Development Apr 14, 2020
@jason0x43 jason0x43 added priority-low We'll get to this eventually domain-reporters Related to Intern's built-in reporters and removed enhancement A new or improved feature priority-medium This should get done, but it's not a high priority labels Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-reporters Related to Intern's built-in reporters effort-medium This may take a couple of days priority-low We'll get to this eventually
Projects
Development

No branches or pull requests

1 participant