Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientSuite doesn't detect top suites properly #86

Closed
rdlukaszl opened this issue Sep 20, 2013 · 0 comments
Closed

ClientSuite doesn't detect top suites properly #86

rdlukaszl opened this issue Sep 20, 2013 · 0 comments
Labels
bug Something that's not working as intended
Milestone
1.3

Comments

@rdlukaszl
Copy link

In the following line https://github.com/theintern/intern/blob/master/lib/ClientSuite.js#L41 ClientSuite checks for suite.parent to detect top suite. I think it should be looking at hasParent flag, as parent field is never sent through proxy. As a result incorrect number of tests is presented to user in the summary.
@bitpshr bitpshr closed this as completed in e3b1585 Oct 2, 2013
stdavis pushed a commit to stdavis/intern that referenced this issue Jun 22, 2015
@bitpshr @stdavis
Use Suite#hasParent instead of Suite#parent
83f4347 
This is needed inside ClientSuite since Suite#parent is not
serialized when using the proxy so tests are incorrectly doubled
up inside the ClientSuite suite.

Fixes theintern#86.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that's not working as intended
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
1 participant
@rdlukaszl