Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added directory/filename support to JUnit #1014

Closed
wants to merge 2 commits into from

Conversation

devpaul
Copy link
Contributor

@devpaul devpaul commented Jan 9, 2020

Added getPath, which handles the progressive fallback of directory/filename options.

I also included comments in Coverage that includes my findings on how it uses filename and directory as a base class (throws them in bags and hands them off to the Istanbul reporters).

The functionality here is done, but perhaps it could use some cleanup since the work has been isolated to JUnit (due to the above discoveries)

Resolves #985

@devpaul devpaul requested a review from jason0x43 January 9, 2020 16:13
@devpaul
Copy link
Contributor Author

devpaul commented Jan 9, 2020

This PR will be applied after the repo reunion: #998

@devpaul devpaul marked this pull request as ready for review January 9, 2020 21:16
@jason0x43
Copy link
Member

After considering this a bit more, I lean towards putting this one on hold until we get around to making more global updates to the reporter system and to Intern's configuration. The root problem is that users need a standard way to specify options for file based reporters, and it seems better to address that all at once rather than piecemeal.

In the end we should have a couple of interfaces (e.g., FileReporterOptions, PathReporterOptions) to cover reporters that output files (like JUnit) and reporters that output into directories (like HtmlCoverage). Reporter options should inherit from one of these (or neither if they don't output files), and the available options for each built in reporter should be encoded in the config schema.

@devpaul
Copy link
Contributor Author

devpaul commented Jan 22, 2020

Closed. Notes added to #1023

@devpaul devpaul closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make options consistent for reporters that generate output
2 participants