Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access WebDriver sourceNode more safely when reference is lost #442

Closed
wants to merge 1 commit into from
Closed

Access WebDriver sourceNode more safely when reference is lost #442

wants to merge 1 commit into from

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jul 17, 2015

Fixes #435

@kitsonk
Copy link
Contributor Author

kitsonk commented Jul 17, 2015

@dylans commented that he prefers a ternary operator to be more explicit about what is going on. I would of course defer to whatever @csnover preferred.

@csnover csnover modified the milestone: 3.0 Jul 27, 2015
@csnover
Copy link
Member

csnover commented Jul 29, 2015

I am actually going to close this PR for now since, while it prevents the crash, there is a better way to do that now. More words about this are at #435 (comment) !

@csnover csnover closed this Jul 29, 2015
@kitsonk kitsonk deleted the issue-435 branch July 29, 2015 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kitsonk @csnover