Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nodeOptions (eg --harmony) to be passed to the new node process #604

Closed
wants to merge 2 commits into from

Conversation

tomdye
Copy link
Contributor

@tomdye tomdye commented Apr 4, 2016

This change allows node options for harmony and other ES6 features to be passed to the child process in which intern is ran when using the grunt intern task.

This is required to enable testing of ES6 code as per dojo/meta#25

Sample usage:

grunt.registerTask('test-es6', function () {
    tsOptions.target = 'es6';
    grunt.config('intern.options. nodeOptions', [
        '--harmony',
        '--harmony_default_parameters'
    ]);
    grunt.task.run('test');
});

Note: Also allows passing debug-brk which is pretty handy

@jason0x43
Copy link
Member

This looks good. How would you feel about nodeOptions rather than nodeFlags?

@tomdye
Copy link
Contributor Author

tomdye commented Apr 4, 2016

Fine by me

On Monday, 4 April 2016, Jason Cheatham notifications@github.com wrote:

This looks good. How would you feel about nodeOptions rather than
nodeFlags?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#604 (comment)

Ursa Minor Consulting Ltd
Mobile: 07793 024 793
Email: tom@ursaminor.co.uk

@tomdye tomdye changed the title Allow nodeFlags (eg --harmony) to be passed to the new node process Allow nodeOptions (eg --harmony) to be passed to the new node process Apr 4, 2016
@tomdye
Copy link
Contributor Author

tomdye commented Apr 4, 2016

@jason0x43 have updated appropriately

@tomdye
Copy link
Contributor Author

tomdye commented Apr 8, 2016

Will this make the next release?

@tomdye tomdye closed this Apr 11, 2016
@tomdye tomdye reopened this Apr 11, 2016
@jason0x43
Copy link
Member

Merged in 05a28c7. Thanks!

@jason0x43 jason0x43 closed this Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants