Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage is making source map locations invalid #4

Open
jason0x43 opened this issue Mar 27, 2018 · 1 comment
Open

Coverage is making source map locations invalid #4

jason0x43 opened this issue Mar 27, 2018 · 1 comment
Labels

Comments

@jason0x43
Copy link
Member

Without the coverage loader:

× node - EventProxy - #getElementTextPath (0.002s)
    AssertionError: expected 'BODY[1][normalize-space(string())="Hello, world"]' to equal '/HTML/BODY[1][normalize-space(string())="Hello, world"]'
      at Test.#getElementTextPath [as test]  <webpack:/tests/unit/EventProxy.ts:202:11>
      at <src/lib/Test.ts:260:47>

With the coverage loader:

× node - EventProxy - #getElementTextPath (0.002s)
    AssertionError: expected 'BODY[1][normalize-space(string())="Hello, world"]' to equal '/HTML/BODY[1][normalize-space(string())="Hello, world"]'
      at Test.#getElementTextPath [as test]  <webpack:/tests/unit/EventProxy.ts:1:32180>
      at <src/lib/Test.ts:260:47>

Note the source locations in tests/unit/EventProxy.ts.

@jason0x43 jason0x43 added the bug label Mar 27, 2018
@jason0x43
Copy link
Member Author

Note that the case above is somewhat invalid because the the test code itself was being instrumented, which shouldn't typically be done. However, the base problem of instrumentation breaking source locations still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant