Skip to content

Commit

Permalink
Remove manual fPIC setup
Browse files Browse the repository at this point in the history 
It is introduced in Conan 1.4.0
  • Loading branch information
@theirix
theirix committed May 29, 2019
1 parent e5e2fa0 commit 641ee68
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion conanfile.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ def build(self):
cmake.definitions['JSONCPP_WITH_TESTS'] = False
cmake.definitions['BUILD_SHARED_LIBS'] = self.options.shared
cmake.definitions['BUILD_STATIC_LIBS'] = not self.options.shared
cmake.definitions['CMAKE_POSITION_INDEPENDENT_CODE'] = self.options.use_pic

cmake.configure(source_folder=self._source_subfolder)
cmake.build()
Expand Down

1 comment on commit 641ee68

@lefticus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to have broken my use case. I need a static version with -fPIC but removing this means my latest builds of jsoncpp aren't building as expected.

And since this is tied to the same 1.8.4 version, I have no way of getting a correct build at the moment. I'm using conan 1.16.0. @theirix

Please sign in to comment.