Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot refresh state #29

Closed
theiskaa opened this issue Jul 27, 2021 · 2 comments · Fixed by #30
Closed

Cannot refresh state #29

theiskaa opened this issue Jul 27, 2021 · 2 comments · Fixed by #30
Assignees
@theiskaa
Labels
bug Something isn't working

Comments

@theiskaa
Copy link
Member

Bug Description:

When we try to remove an item from our suggestion list, then already opened suggestion box cannot understand that so it didn't update.
However, FieldSuggestion's BoxController should have a refresh functionality to refresh widget after local changes.

Reported by: @g-scota

To Reproduce

Steps to reproduce the behavior:

  1. Make a field suggestion widget (by builder).
  2. Add remove functionality to Suggestion Item. and try that functionality
@theiskaa theiskaa added the bug Something isn't working label Jul 27, 2021
@theiskaa theiskaa self-assigned this Jul 27, 2021
This was referenced Jul 27, 2021
Merged
Closed
@g-scosta
Copy link

g-scosta commented Jul 27, 2021 •
edited

Great! Thanks for the fast fix! This will cover more than the solution I proposed. The gif in the PR explains it all. Well done!

@theiskaa
Copy link
Member Author

@g-scosta You're welcome! Okay, then I'll merge it and release a new version 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theiskaa theiskaa

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

State refreshing insolite-dev/field_suggestion
2 participants
@theiskaa @g-scosta