Use unpack_index from our code #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
=========================================
- Coverage 73.61% 73.6% -0.02%
=========================================
Files 11 11
Lines 2009 2008 -1
=========================================
- Hits 1479 1478 -1
Misses 530 530
Continue to review full report at Codecov.
|
flying-sheep
force-pushed
the
unpack-index
branch
from
7fb7588
to
9ce9d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146
I chose to not implement Ellipsis handling since they make no sense for 2D matrices.
And unlike sparse matrices, for which the original IndexMixin was written, AnnData objects will never occur in place of some ndarray where people might use ellipses to slice them.