Bug fix for smallest_dot in sc.pl.dotplot()
#1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
=======================================
Coverage 71.21% 71.22%
=======================================
Files 92 92
Lines 11181 11181
=======================================
+ Hits 7963 7964 +1
+ Misses 3218 3217 -1
|
ivirshup
requested changes
Mar 31, 2021
There was a problem hiding this comment.
Thanks for the PR! Yeah, this looks like a typo, and your fix looks good.
Could you update the reference plot for the tests? This will just entail replacing the reference figure with the new figure generated by the failing test? This may need to happen for all the tests which use smallest_dot.
|
Hi @ivirshup , I replaced the one test image that was causing a failure, as you suggested. (And I checked to make sure the image makes sense... it does...) I think this should do it. |
|
Looks good, thanks! |
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
May 25, 2021
ivirshup
pushed a commit
that referenced
this pull request
May 25, 2021
Co-authored-by: Stephen Fleming <sjfleming@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1770