Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paga exact reproducibility #1922

Merged
merged 9 commits into from Nov 3, 2021

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Jul 5, 2021

Fixes #1859

igraph uses python's random state, not numpy's.

TODO:

  • Update saved examples for tests
  • Release note

@ivirshup ivirshup added this to the 1.8.1 milestone Jul 5, 2021
@ivirshup ivirshup marked this pull request as draft July 5, 2021 08:33
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1922 (4e0f21c) into master (1b74015) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head 4e0f21c differs from pull request most recent head 92cbaae. Consider uploading reports for the commit 92cbaae to get more accurate results

@@            Coverage Diff             @@
##           master    #1922      +/-   ##
==========================================
- Coverage   71.63%   71.62%   -0.01%     
==========================================
  Files          92       92              
  Lines       11248    11248              
==========================================
- Hits         8057     8056       -1     
- Misses       3191     3192       +1     
Impacted Files Coverage Δ
scanpy/plotting/_tools/paga.py 70.98% <83.33%> (+0.30%) ⬆️
scanpy/cli.py 91.30% <0.00%> (-1.45%) ⬇️
scanpy/tools/_rank_genes_groups.py 93.87% <0.00%> (-0.33%) ⬇️

@ivirshup ivirshup requested a review from falexwolf July 5, 2021 09:51
@ivirshup ivirshup marked this pull request as ready for review July 5, 2021 10:09
@ivirshup ivirshup modified the milestones: 1.8.1, 1.8.2 Jul 7, 2021
@ivirshup ivirshup enabled auto-merge (squash) November 3, 2021 14:04
@ivirshup ivirshup merged commit d02fc4d into scverse:master Nov 3, 2021
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Nov 3, 2021
ivirshup added a commit that referenced this pull request Nov 3, 2021
Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PAGA layout not reproducible
1 participant