Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.0 #44

Merged
merged 2 commits into from
Jan 22, 2022
Merged

0.5.0 #44

merged 2 commits into from
Jan 22, 2022

Conversation

thejandroman
Copy link
Owner

After moving to Arch I decided to give this forgotten script a try. It didn't work. It was also very complicated. URL parsing from JSON is a crazy thing to try to do in a bash script. I don't have a Mac to test these changes on but hopefully everything still works. There were a number of overlapping PRs over the years that made it into this revision. I've tried to add credit to the original PRs where applicable.

Summary of changes:

  1. Merge latest and boost code paths (From @Lyncredible in Uses jq to parse json output from Bing.com #39)
  2. Use https for all requests if -s (From @Lyncredible in Uses jq to parse json output from Bing.com #39)
  3. Update URL patterns (From @Lyncredible in Uses jq to parse json output from Bing.com #39, @microdog in Update url pattern and fix boost mode #36, @nitrogear in Syntax error on macOS High Sierra 10.13.6 #23)
  4. Add UHD support (fixes UHD #43)
  5. Remove contributing.json as it wasn't used anymore
  6. Remove travis badge as we now use actions

After moving to Arch I decided to give this forgotten script a try. It didn't work. It was also very complicated. URL parsing from JSON is a crazy thing to try to do in a bash script. I don't have a Mac to test these changes on but hopefully everything still works. There were a number of overlapping PRs over the years that made it into this revision. I've tried to add credit to the original PRs where applicable.

Summary of changes:

1. Merge latest and boost code paths (From @Lyncredible in #39)
2. Use https for all requests if -s (From @Lyncredible in #39)
3. Update URL patterns  (From @Lyncredible in #39, @microdog in #36, @nitrogear in #23)
4. Add UHD support (fixes #43)
5. Remove contributing.json as it wasn't used anymore
@thejandroman thejandroman mentioned this pull request Jan 18, 2022
Closed
@thejandroman thejandroman merged commit b13b919 into master Jan 22, 2022
@thejandroman thejandroman deleted the 0.5.0 branch January 22, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UHD
1 participant