-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support assimp 3.1.1 #119
Comments
We're probably using a post processing flag which has been removed, or which isn't valid in some cases. |
Might be this We'll have to check that all of our postprocess flags are valid |
The assertion is due to that we use both 'aiProcess_OptimizeGraph' and 'aiProcess_PreTransformVertices'. Also the zombies are not visible any more with assimp 3.1.1... From Importer.cpp // Validate post process step flags
bool _ValidateFlags(unsigned int pFlags)
{
if (pFlags & aiProcess_GenSmoothNormals && pFlags & aiProcess_GenNormals) {
DefaultLogger::get()->error("#aiProcess_GenSmoothNormals and #aiProcess_GenNormals are incompatible");
return false;
}
if (pFlags & aiProcess_OptimizeGraph && pFlags & aiProcess_PreTransformVertices) {
DefaultLogger::get()->error("#aiProcess_OptimizeGraph and #aiProcess_PreTransformVertices are incompatible");
return false;
}
return true;
} |
…ces flag. 'aiProcess_OptimizeGraph' and 'aiProcess_PreTransformVertices' cannot be used at the same time. This might not be the best solution, but fixes the assimp 3.1.1 assertion for custom map meshes. TODO: Zombies are not visible when using assimp 3.1.1.
Note that the issue with zombies not rendering appears to be only related to the Zombie model. Other models are rendering fine - even other models with animations. |
When I run
assimp 3.1.1 gives this instead:
It appears to think that the model is much smaller than it actually is. This might be a regression. |
I might be this assimp/assimp@d411cbfbf4a5f0 |
Not possible to run with assimp 3.1.1 instead of 3.0. Reported by issue #118
Source used (Pacman for Arch):
http://sourceforge.net/projects/assimp/files/assimp-3.1/
Changes in 3.1.1:
https://github.com/assimp/assimp/blob/master/CHANGES
Arch and Ubuntu 15.04:
chaoticrage: /assimp/assimp-3.1.1/code/Importer.cpp:738: const aiScene* Assimp::Importer::ApplyPostProcessing(unsigned int): Assertion `_ValidateFlags(pFlags)' failed.
Aborted (core dumped)
The text was updated successfully, but these errors were encountered: