Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could do with a code review. #1

Closed
thejpster opened this issue Feb 4, 2018 · 4 comments
Closed

Could do with a code review. #1

thejpster opened this issue Feb 4, 2018 · 4 comments

Comments

@thejpster
Copy link
Member

No description provided.

@jamesmunns
Copy link
Member

@thejpster hey, I'm bitshiftmask from IRC. Feel free to tag me, hopefully I can check this out tonight or tomorrow

@thejpster
Copy link
Member Author

I've been working in master, so feel free to cast your eye over that. Serial, GPIO and busy-wait delays are done - largely based on stm32f30x-hal. The other modules will be broadly similar in style.

@thejpster
Copy link
Member Author

Much appreciated, by the way! Also, Zurich was excellent.

@thejpster
Copy link
Member Author

This was in PR #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thejpster @jamesmunns