chapter10.md: some missing lines of codes

[Jemaz]

At the "Splitting the program into functions", the particular code is written as:
// Get movies by Christopher Nolan const nolanMovies = () => { for (const movie of movieList) { if (movie.director === "Christopher Nolan") { nolanMovieList.push(movie); } } };

Where it should be:
// Get movies by Christopher Nolan const nolanMovies = () => { const nolanMovieList = []; for (const movie of movieList) { if (movie.director === "Christopher Nolan") { nolanMovieList.push(movie); } } return nolanMovieList; };

[Jemaz]

Excuse me for the bad formatting, still a newb to this.

[vsemozhetbyt]

@Jemaz It seems this function uses the global variable that is declared below in that code fragment:

//...
const nolanMovieList = [];

console.log(titles());
// ...

[vsemozhetbyt]

@Jemaz About formatting, you can read here:

https://help.github.com/articles/creating-and-highlighting-code-blocks/

Just use js or javascript label instead of ruby from the example in that help chapter)

[Jemaz]

@vsemozhetbyt Thanks truly for the formatting advice!
So there's a couple things wrong with it as I was doing the tutorial:

1. The section is basically turning global vars into local vars by turning into functions (as I understood to eliminate any side-effects), the author did so except for the anonymous function "nolanMovies" which defeats the purpose of the exercise - which confused like a beginner like me
2. It's missing a return statement

[vsemozhetbyt]

@Jemaz I suppose both using the global variable and omitting the return are intended to show how a not pure function operates. It is a bit dizzying from the final point of view, but maybe this is the very sense of it)

[vsemozhetbyt]

What was a bit more confusing for me: why the final byNolan() was not refactoring into the more generic byDirector(director). But this can also be intended to make the transition from the old code to the new one more smooth.

[bpesquet]

Thanks for your feedback. This chapter gave me a lot of headaches and is probably still too confusing. I leave this issue open in case someone else can provide good advice for improving it.