Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts k8s apiextensions v1beta1 to v1 #124

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Converts k8s apiextensions v1beta1 to v1 #124

merged 3 commits into from
Aug 12, 2021

Conversation

stinkyfingers
Copy link
Contributor

@stinkyfingers stinkyfingers commented Aug 10, 2021

Description

915.

  • Switch Kubernetes API versions from */v1beta1 to */v1. After k8s 1.16, CustomResourceDefinions are in apiextensions.k8s.io/v1, rather than v1beta1.
  • Upgrades controller-gen, so crdVersion will be v1 in the future.
  • Upgrades kubebuilder version so bundled kube-apiserver will be >= kubernetes 1.16
  • Adds check in unit tests to assure that k8s version is >= 1.16
  • rbac.authorization.k8s.io/v1 and admissionregistration.k8s.io/v1 are also out of beta.
  • Webhook manifests have slightly different structure.
  • Lots of changes to the generated manifests.

Fixes # 915

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Updates helm to 3.6.3 (#123)

* updates helm dep to 3.6.3 and all other things that depend on that version

* put cancelfunc on context in setup

finish updates
@stinkyfingers stinkyfingers merged commit 022d37a into main Aug 12, 2021
@stinkyfingers stinkyfingers deleted the shipa-915 branch August 12, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants