Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipa 1823 #125

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Shipa 1823 #125

merged 2 commits into from
Aug 27, 2021

Conversation

stinkyfingers
Copy link
Contributor

@stinkyfingers stinkyfingers commented Aug 26, 2021

Description

Testing revealed some missing permissions. Adds permission to manage leases and to manage jobs & jobs/status.

Fixes # 1823

Testing release:

minikube delete -p ketch-cluster
minikube start -p ketch-cluster --driver=hyperkit
helm install traefik traefik/traefik
kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v1.0.3/cert-manager.yaml
kubectl apply -f https://github.com/shipa-corp/ketch/releases/download/v0.5.0-rc-3/ketch-controller.yaml
minikube tunnel -p ketch-cluster
curl -s https://raw.githubusercontent.com/shipa-corp/ketch/main/install.sh | INSTALL_DIR=. TAG=v0.5.0-rc-3  bash
mv ./ketch /usr/local/bin/ketch
ketch framework add myframework --ingress-service-endpoint "$(k get svc traefik -o jsonpath='{.status.loadBalancer.ingress[0].ip}')" --ingress-type traefik
ketch app deploy test --framework myframework -i gcr.io/kubernetes-312803/sample-go-app:latest
ketch job deploy j.yaml
ketch deploy a.yaml

j.yaml

name: myjob
version: v1
type: Job
framework: myframework
description: "cli test job"
containers:
  # prints 200 digits of pi
  - name: pi
    image: perl
    command:
      - "perl"
      - "-Mbignum=bpi"
      - "-wle"
      - "print bpi(2000)"
  # list root dir
  - name: list
    image: ubuntu
    command:
      - ls
      - "/"

a.yaml

version: v1
type: Application
name: test-go
image: gcr.io/kubernetes-312803/sample-go-app:latest
framework: myframework
description: a test in GO
cname:
  dnsName: heygo.10.103.78.78.shipa.cloud # for forget to modify: k get svc traefik -o jsonpath='{.status.loadBalancer.ingress[0].ip}'
environment:
  - FOO=golang

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Copy link
Contributor

@c12o16h1 c12o16h1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stinkyfingers stinkyfingers merged commit 7961e75 into main Aug 27, 2021
@stinkyfingers stinkyfingers deleted the shipa-1823 branch August 27, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants