Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Job completions to parallelism and add acceptance test #126

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

stinkyfingers
Copy link
Contributor

Description

Job completions value should default to the parallelism value if unset (per discussion w/ Vivek and K8s Job docs). Adds an integration test that asserts that Job completions and parallelism values are as expected.

Fixes # 1865 - this is the 3rd item listed in this issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@stinkyfingers stinkyfingers merged commit 62dce60 into main Aug 30, 2021
@stinkyfingers stinkyfingers deleted the shipa-1865 branch August 30, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants