Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify error message to user when framework already exists #127

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

stinkyfingers
Copy link
Contributor

@stinkyfingers stinkyfingers commented Aug 30, 2021

Description

The error message to the user when trying to create a framework that already exists is unclear. This PR just checks the error and displays a clearer message. Adds test. If there's a better way to clarify errors generated by webhooks, let me know.

This is the first item in issue below:

Fixes # 1865

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@stinkyfingers stinkyfingers force-pushed the shipa-1865-framework branch 2 times, most recently from e044a8c to 0b9724a Compare August 30, 2021 17:22
test wait

chase test err

fix test err check

ping
@stinkyfingers stinkyfingers merged commit 40d610d into main Aug 31, 2021
@stinkyfingers stinkyfingers deleted the shipa-1865-framework branch August 31, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants