Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHIPA-828 Add Platform CRUD #41

Closed
wants to merge 9 commits into from
Closed

SHIPA-828 Add Platform CRUD #41

wants to merge 9 commits into from

Conversation

murphybytes
Copy link
Contributor

Description

This PR adds a Platform CRD and adds CLI commands to add, list and delete platforms. See SHIPA-828.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

aleksej-paschenko
aleksej-paschenko reviewed Dec 17, 2020
View reviewed changes
cmd/ketch/platform_add.go Outdated Show resolved Hide resolved
cmd/ketch/platform_add.go Outdated Show resolved Hide resolved
cmd/ketch/platform.go Outdated Show resolved Hide resolved
cmd/ketch/platform_add.go Outdated Show resolved Hide resolved
cmd/ketch/platform_list_test.go Outdated Show resolved Hide resolved
internal/api/v1beta1/platform_types.go Show resolved Hide resolved
internal/chart/platform_chart.go Outdated Show resolved Hide resolved
cmd/ketch/platform_add_test.go Outdated Show resolved Hide resolved
cmd/ketch/platform.go Outdated Show resolved Hide resolved
aleksej-paschenko
aleksej-paschenko reviewed Dec 21, 2020
View reviewed changes
Copy link
Contributor

@aleksej-paschenko aleksej-paschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome
I know it is a bit annoying but can we use out instead of logWriter?

cmd/ketch/platform_add.go Outdated Show resolved Hide resolved
cmd/ketch/platform_add.go Outdated Show resolved Hide resolved
cmd/ketch/platform_delete.go Outdated Show resolved Hide resolved
cmd/ketch/platform_list.go Outdated Show resolved Hide resolved
cmd/ketch/platform_list.go Show resolved Hide resolved
@vivek
Copy link
Contributor

vivek commented Jun 30, 2021

platform is no longer supported, closing it.

@vivek vivek closed this Jun 30, 2021
@aleksej-paschenko aleksej-paschenko deleted the shipa-828 branch December 24, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksej-paschenko aleksej-paschenko aleksej-paschenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@murphybytes @vivek @aleksej-paschenko