Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to angular 14 #110

Merged
merged 1 commit into from
Jun 24, 2022
Merged

update to angular 14 #110

merged 1 commit into from
Jun 24, 2022

Conversation

johnmckay-reward
Copy link
Contributor

@johnmckay-reward johnmckay-reward commented Jun 23, 2022

Have updated the library to support Angular 14, have also updated Jest

#109

@johnmckay-reward
Copy link
Contributor Author

image

@thekip
Copy link
Owner

thekip commented Jun 24, 2022

Thanks for PR, I think, is it possible to support 13 & 14 versions simultaneously?

Because there no changes in the code, and no big changes in the compiler, probably it's just matter of adding both of this versions to this lib package.json

@johnmckay-reward
Copy link
Contributor Author

Have updated the PR based on this StackOverflow answer -> https://stackoverflow.com/a/60828558/969613

Thanks

@thekip thekip merged commit fe0c635 into thekip:master Jun 24, 2022
@thekip
Copy link
Owner

thekip commented Jun 24, 2022

Merged, and deployed as 3.0.1, thanks for the help.

@johnmckay-reward
Copy link
Contributor Author

No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants