Miles/test releases #1
Conversation
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
1d90352
to
4ea68da
Compare
| # wget https://downloads.apache.org/cassandra/KEYS | ||
| # cd downloads.apache.org/cassandra/ | ||
| # mv redhat/311x/* redhat/ | ||
| mv KEYS redhat |
| echo | ||
| rm -f procfifo | ||
| mkfifo procfifo | ||
| docker run -i -v `pwd`/redhat:/redhat centos timeout 180 /bin/bash -c "( rpm --import /redhat/KEYS; rpm -K /redhat/*.rpm);" 2>&1 >procfifo & |
There was a problem hiding this comment.
Rather than run the centos container twice, can we add --import /redhat/KEYS to line 103 above? (adding the [[ $LINE =~ ".*digests SIGNATURES NOT OK" ]] conditional block in before the [[ $LINE =~ "Starting listening for CQL clients on" ]] block)
|
wrt 031aeee and 8ad9e85 i think we can do better. A hurdle with this approach is that if it breaks there's nothing we can do about it (except wait and hope that the next release fixes it). A better approach would be to put these debian and redhat "start up" smoke tests into our existing CI pipeline. We already build on these distributions to test the packaging of each works, so extending that to check that the built package also starts up seems a reasonable extension to add. |
| @@ -26,7 +26,7 @@ function test_deb() { | |||
| HEAP_NEWSIZE=500m MAX_HEAP_SIZE=1g cassandra -R -f | |||
| " | |||
| rm -f procfifo && mkfifo procfifo | |||
| docker run -i openjdk:8-jdk-slim-buster timeout 180 /bin/bash -c $COMMAND 2>&1 >procfifo & | |||
| docker run -i openjdk:8-jdk-slim-buster timeout 360 /bin/bash -c $COMMAND 2>&1 >procfifo & | |||
There was a problem hiding this comment.
yes, this change was also made in the original PR
( 4ea68da#diff-a636443cd5bfb43c9eddbf4ea4ce8546d63190b9326266245ab0068984fe59c1R84 )
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
4ea68da
to
5e6a4a3
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
5e6a4a3
to
fc22ab0
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
fc22ab0
to
c316892
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
2 times, most recently
from
029d0ab
to
12e7d81
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
4 times, most recently
from
88e8e13
to
4b2f607
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
4b2f607
to
dbf5d81
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
5 times, most recently
from
bed5d51
to
0e53ce4
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
2 times, most recently
from
5996107
to
f5a33a8
Compare
@michaelsembwever are you happy to take these changes forward?
I need to go away and read the cassanda-ci confluence to figure out how to get
test-releases.shscheduled, but I'm really drinking from the firehose at the moment and won't get to that immediately.At least if these are merged on your fork then they won't be lost hopefully.