Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket-name cli argument for RO commands #589

Open
azarnovdaniil opened this issue May 29, 2023 · 4 comments · May be fixed by #590
Open

Add bucket-name cli argument for RO commands #589

azarnovdaniil opened this issue May 29, 2023 · 4 comments · May be fixed by #590
Labels
blocked Issues in the state 'blocked' help-wanted Issues in the state 'help-wanted' stale

Comments

@azarnovdaniil
Copy link
Contributor

azarnovdaniil commented May 29, 2023

Project board link

Hi!

Typical scenario - restoring one cluster to another. In this case, changing the backet_name in the config all time and reverting it is not convenient, as many manual operations and places for mistakes, and also a chance to start backup operation to another bucket(manually or cron).

It will be better to have arg with bucket-name for RO commands and use arg for the above scenario and one SA with RO access in all buckets because restoring is, most time, a manual operation.

@adejanovski adejanovski added the new Issues requiring triage label May 29, 2023
@azarnovdaniil azarnovdaniil changed the title Add configuring bucket-name from args for RO commands Add bucket-name cli argument for RO commands Jun 1, 2023
@adejanovski
Copy link
Contributor

I think that's a good idea. I had thought of it in the past as well.
Now, do you think about going as far as specifying a secondary set of connection settings along with separate credentials? That could be challenging given how we handle connections in Medusa.
Now, if it's just about specifying a different bucket name but reusing the same credentials, I guess that could be simpler (although we'd have to double check this).

If you feel like contributing this feature, it would be much appreciated :)
I guess we'd need to see how this could be designed first though.

@adejanovski adejanovski added assess Issues in the state 'assess' and removed to-groom labels Jun 19, 2023
@azarnovdaniil
Copy link
Contributor Author

@adejanovski Hi! Thanks for the answer. I made PR #590 with my implementation of this feature.

  1. Should we also configure prefixes from args?
  2. About keys, I think that we should not use separate keys here. General best practice for cloud - using SA attached to a host, without SA keys, and in this case, we cannot attach two SA.

@adejanovski
Copy link
Contributor

oh, I couldn't see the linked PR from the ticket because of how the ticket was referred to in the description (see this).

I'll add the review to my todo list.

Should we also configure prefixes from args?

I think it would be nice indeed.

About keys, I think that we should not use separate keys here. General best practice for cloud - using SA attached to a host, without SA keys, and in this case, we cannot attach two SA.

I agree 👍

@azarnovdaniil
Copy link
Contributor Author

azarnovdaniil commented Jun 28, 2023

@adejanovski

I think it would be nice indeed.

I added a configurable prefix.

@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' and removed new Issues requiring triage assess Issues in the state 'assess' labels Jun 29, 2023
@adejanovski adejanovski added review Issues in the state 'review' and removed ready-for-review Issues in the state 'ready-for-review' labels Jul 21, 2023
@adejanovski adejanovski added blocked Issues in the state 'blocked' and removed review Issues in the state 'review' labels Jan 26, 2024
@rzvoncek rzvoncek added to-groom stale help-wanted Issues in the state 'help-wanted' and removed blocked Issues in the state 'blocked' labels Apr 3, 2024
@adejanovski adejanovski added blocked Issues in the state 'blocked' help-wanted Issues in the state 'help-wanted' and removed help-wanted Issues in the state 'help-wanted' to-groom blocked Issues in the state 'blocked' labels Apr 8, 2024
@rzvoncek rzvoncek added help wanted Extra attention is needed and removed help-wanted Issues in the state 'help-wanted' labels Apr 8, 2024
@rzvoncek rzvoncek added the blocked Issues in the state 'blocked' label Apr 8, 2024
@adejanovski adejanovski added help-wanted Issues in the state 'help-wanted' blocked Issues in the state 'blocked' and removed blocked Issues in the state 'blocked' help-wanted Issues in the state 'help-wanted' labels Apr 8, 2024
@rzvoncek rzvoncek added help-wanted Issues in the state 'help-wanted' and removed help wanted Extra attention is needed labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues in the state 'blocked' help-wanted Issues in the state 'help-wanted' stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants