Better handle runner concurrency #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
approved these changes
Jun 9, 2022
|
Is it possible that this prevents reaper from running parallel repairs on different clusters? It looks like old code checked existing runs filtering them by cluster name but now there is no filtering. |
Yes, it's the case. And we need to address this so that the limit applies per cluster. |
|
I created an issue to track this. |
max-melentyev
added a commit
to max-melentyev/cassandra-reaper
that referenced
this pull request
Feb 1, 2023
After thelastpickle#1197 active repairs in one cluster prevent repairs in others. This diff makes repairs in different clusters independent again.
max-melentyev
added a commit
to max-melentyev/cassandra-reaper
that referenced
this pull request
Feb 1, 2023
After thelastpickle#1197 active repairs in one cluster prevent repairs in others. This diff makes repairs in different clusters independent again.
adejanovski
pushed a commit
that referenced
this pull request
Feb 9, 2023
After #1197 active repairs in one cluster prevent repairs in others. This diff makes repairs in different clusters independent again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of limiting the number of concurrent runners is done by checking the number of runners in the local Reaper instance. Paused runs still have a runner thread, which gets counted as well, resulting in paused repairs potentially blocking other repairs.
Another problem that can arise is that different reaper instance could start runs in a different order, resulting in different runs being authorized depending on the instance.
The current set of changes orders the runners by repair run creation date (the run id is a timeuuid), to prioritize older runs, and also takes into account the state of the run, so that paused runs let running one be processed.