Updated the registry clusters entrypoint to support the use of custom username and password combinations #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… username and password, maintained support for default admin credentials if values are not used
adejanovski
approved these changes
Sep 12, 2022
|
Great project @adejanovski, thanks for the review 👍 |
adejanovski
pushed a commit
that referenced
this pull request
Nov 3, 2022
… username and password, maintained support for default admin credentials if values are not used (#1224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the register clusters entrypoint sets the password to "admin" in the credentials file and fails on authentication if any other username/password combination is used. This value is picked up by the get_password method in the spreaper, as this finds the value in the file, and thus attempts authentication with this hard coded value.
This PR maintains the default support for the default username and password while allowing those who change the username/password for the Cassandra Reaper to also use these via environment variable (REAPER_AUTH_USER and REAPER_AUTH_PASSWORD).
This would enable more flexible use of this register-cluster method while allowing better security though stronger credentials in its usage.