Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology change resilience for incremental repair #1235

Merged
merged 22 commits into from
Nov 16, 2022
Merged

Topology change resilience for incremental repair #1235

merged 22 commits into from
Nov 16, 2022

Commits on Nov 8, 2022

  1. Migration file to add host_id to repair_run table.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    0593f56 View commit details
    Browse the repository at this point in the history

  2. Changes to CassandraStorage to read/write new hostID field.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    52f1261 View commit details
    Browse the repository at this point in the history

  3. Changes to RepairSegment class to include new hostID field.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    95f0eae View commit details
    Browse the repository at this point in the history

  4. RepairRunService now adds in hostID for every repair RepairSegment it… 

    … creates.
    @Miles-Garnsey
    Miles-Garnsey committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    72a53d3 View commit details
    Browse the repository at this point in the history

  5. RepairRunner now consults the hostID field for the nominated segment … 

    …and looks up its current IP when determining the list of potential coordinators.
    @Miles-Garnsey
    Miles-Garnsey committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    92643af View commit details
    Browse the repository at this point in the history

  6. Test for topology change when running incremental repairs.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    f4f931c View commit details
    Browse the repository at this point in the history

  7. Make checkstyle happy.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    f5ae5bd View commit details
    Browse the repository at this point in the history

  8. Tweaks to the way hostID is instantiated on RepairSegment.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    91ef907 View commit details
    Browse the repository at this point in the history

  9. Better mocks for the test.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    7d2a410 View commit details
    Browse the repository at this point in the history

  10. Update mocks in failIncrRepairRunCreationTest to cater to new use of … 

    …getEndpointToHostId.
    @Miles-Garnsey
    Miles-Garnsey committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    d25a9e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. HostID is only added where the repair run is incremental.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    8f74d82 View commit details
    Browse the repository at this point in the history

  2. Tweak error messages in RepairRunner.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    6fa57f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Remove extra if statement from createRepairSegmentsForIncrementalRepair.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    0431d5b View commit details
    Browse the repository at this point in the history

  2. Test method addNewRepairRun needs to set the hostID for incremental… 

    … repair tests.
    @Miles-Garnsey
    Miles-Garnsey committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    16f0052 View commit details
    Browse the repository at this point in the history

  3. Fix up testDontFailRepairAfterTopologyChangeIncrementalRepair so th… 

    …at the coordinator is the node that gets swapped out.
    @Miles-Garnsey
    Miles-Garnsey committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    c186b9a View commit details
    Browse the repository at this point in the history

  4. addNewRepairRun was still missing a hostID on its second returned e… 

    …lement.
    @Miles-Garnsey
    Miles-Garnsey committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    12a15f6 View commit details
    Browse the repository at this point in the history

  5. Don't throw exceptions when there are no potential replicas.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    248c9ae View commit details
    Browse the repository at this point in the history

  6. Comments and optimisations.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    0989743 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Checkstyle...

    @Miles-Garnsey
    Miles-Garnsey committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    04f2d5d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Ensure createRepairSegmentFromRow storage function hydrates the hostI… 

    …D field in RepairSegment.
    @Miles-Garnsey
    Miles-Garnsey committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    e8a2d04 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. (Courtesy of Alexander Dejanovski) ensure that the segmentReplicas ar… 

    …e correctly propagated into the potentialCoordinators so that repairs correctly pick them up.
    @Miles-Garnsey
    Miles-Garnsey committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    aff7669 View commit details
    Browse the repository at this point in the history

  2. Change some info level logs to debug.

    @Miles-Garnsey
    Miles-Garnsey committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    4a0d51a View commit details
    Browse the repository at this point in the history