Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip dash and underscore from metrics' tags #1267

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@ private MetricNameUtils() {
}

public static String cleanName(String name) {
return name.replaceAll("[^A-Za-z0-9]", "");
return name.replaceAll("[^A-Za-z0-9\\-_]", "");
}

public static String cleanId(UUID uuid) {
return uuid.toString().replaceAll("-", "");
return uuid.toString();
}

public static String cleanHostName(String hostname) {
return Optional.ofNullable(hostname).orElse("null")
.replace('.', 'x')
.replaceAll("[^A-Za-z0-9]", "");
.replace('.', '-')
.replaceAll("[^A-Za-z0-9\\-_]", "");
}
}