Changes Exception to a Reaper Exception #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen reaper exiting dueing this condition and this turns it into a reaper exception instead of hitting the assertion in computeGlobalSegmentCount.
|
No linked issues found. Please add the corresponding issues in the pull request description. |
|
Will fix checkstyle violations when this looks like a patch we want to pursue... |
|
Hi @xgerman, we can move forward with this PR and merge it once you get CI to pass 👍 |
This makes it so that reaper doesn't crashes tight away if a ks has been removed.
xgerman
added a commit
to microsoft/cassandra-reaper
that referenced
this pull request
Feb 26, 2024
* Don't exit reaper if endpointToRange is empty and segment count 0 We have seen reaper exiting dueing this condition and this turns it into a reaper exception instead of hitting the assertion in computeGlobalSegmentCount. * Makes an AssertionError a Reaper Exception This makes it so that reaper doesn't crashes tight away if a ks has been removed. --------- Co-authored-by: German Eichberger <geeichbe@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mitigate #1038
Instead of crashing the JVM we are wrapping the error into a ReaperException to mitigate the issue.